Skip to content
Snippets Groups Projects

Move all Intersection code from ptr to optional or value

Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:IIntersector_cleanup into main

Move all Intersection code from ptr to optional or value

This ended up including a removal of quite a bit of obsolete code

Edited by Christos Anastopoulos

Merge request reports

Pipeline #6482305 passed

Pipeline passed for fa3c2f29 on ATLAS-EGamma:IIntersector_cleanup

Merged by Walter LamplWalter Lampl 1 year ago (Nov 15, 2023 2:10pm UTC)

Merge details

  • Changes merged into with 9e303a6c.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Christos Anastopoulos resolved all threads

    resolved all threads

  • Jenkins please retry a build

  • This merge request affects 13 packages:

    • MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPattern
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/TGC_LinearSegmentMakerTool
    • Reconstruction/MuonIdentification/MuidCaloIsolationTools
    • Tracking/TrkExtrapolation/TrkExAlgs
    • Tracking/TrkExtrapolation/TrkExInterfaces
    • Tracking/TrkExtrapolation/TrkExRungeKuttaIntersector
    • Tracking/TrkExtrapolation/TrkExRungeKuttaPropagator
    • Tracking/TrkExtrapolation/TrkExSTEP_Propagator
    • Tracking/TrkExtrapolation/TrkExSolenoidalIntersector
    • Tracking/TrkExtrapolation/TrkExStraightLineIntersector
    • Tracking/TrkExtrapolation/TrkExUtils
    • Tracking/TrkFitter/TrkiPatFitter
    • Tracking/TrkFitter/TrkiPatFitterUtils

    Affected files list will not be printed in this case

    Adding @pscholer ,@goetz ,@jojungge ,@gavrilen ,@pop ,@apsallid ,@kluit ,@stavrop ,@rosati as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 120K in file Tracking/TrkExtrapolation/TrkExSTEP_Propagator/src/STEP_Propagator.cxx

  • :white_check_mark: CI Result SUCCESS (hash 4a906013)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1137]

  • Christos Anastopoulos marked this merge request as ready

    marked this merge request as ready

  • @sroe for the code you pointed is not touched from this MR. But yea there is scope for furthr cleanups . But this is a bit different from what I try here.

    Basically we had a few new/delete close together which I would like to get rid off or try to

  • added 1 commit

    • 45bb3f00 - rm TGC_LinearSegmentMakerTool

    Compare with previous version

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading