Skip to content
Snippets Groups Projects

VP1BanksPlugin+VP1TriggerDecisionPlugin: slots -> Q_SLOTS

Merged Scott Snyder requested to merge ssnyder/athena:slots.VP1BanksPlugin-20231127 into main
  1. Nov 27, 2023
    • scott snyder's avatar
      VP1TriggerDecisionPlugin: slots -> Q_SLOTS · f0f2e3c6
      scott snyder authored
      Rename the Qt slots 'keyword' to Q_SLOTS.
      
      Having this in the source confuses cppcheck, which reports syntax errors.
      We can define slots as a macro expanding to nothing in the cppcheck
      configuration, but if we do that globally, there are other packages that
      break because they use slots as an identifier.  Using Q_SLOTS instead
      prevents this name collision.
      f0f2e3c6
    • scott snyder's avatar
      VP1BanksPlugin: slots -> Q_SLOTS · 1df9723a
      scott snyder authored
      Rename the Qt slots 'keyword' to Q_SLOTS.
      
      Having this in the source confuses cppcheck, which reports syntax errors.
      We can define slots as a macro expanding to nothing in the cppcheck
      configuration, but if we do that globally, there are other packages that
      break because they use slots as an identifier.  Using Q_SLOTS instead
      prevents this name collision.
      1df9723a
Loading