Skip to content
Snippets Groups Projects

VP1TestSystems+VP1CaloReadoutSystems: slots -> Q_SLOTS

Merged Scott Snyder requested to merge ssnyder/athena:slots.VP1TestSystems-20231127 into main
  1. Nov 27, 2023
    • scott snyder's avatar
      VP1CaloReadoutSystems: slots -> Q_SLOTS · c618872c
      scott snyder authored
      Rename the Qt slots 'keyword' to Q_SLOTS.
      
      Having this in the source confuses cppcheck, which reports syntax errors.
      We can define slots as a macro expanding to nothing in the cppcheck
      configuration, but if we do that globally, there are other packages that
      break because they use slots as an identifier.  Using Q_SLOTS instead
      prevents this name collision.
      c618872c
    • scott snyder's avatar
      VP1TestSystems: slots -> Q_SLOTS · 9c91f479
      scott snyder authored
      Rename the Qt slots 'keyword' to Q_SLOTS.
      
      Having this in the source confuses cppcheck, which reports syntax errors.
      We can define slots as a macro expanding to nothing in the cppcheck
      configuration, but if we do that globally, there are other packages that
      break because they use slots as an identifier.  Using Q_SLOTS instead
      prevents this name collision.
      9c91f479
Loading