Rename barcode in RingerSelectorTools
Rename barcode in RingerSelectorTools. As the campaighn to remove the usage of barcodes in the Athena codes goes on, "barcode" is not a nice name for an identifier.
Renamed for this package to codebar
.
Apart from that, some additional changes:
- use
constexpr
for the integer constants - use
std::filesystem
to get the base name of the file. - drop boost
Merge request reports
Activity
This merge request affects 1 package:
- PhysicsAnalysis/RingerSelectorTools
This merge request affects 3 files:
- PhysicsAnalysis/RingerSelectorTools/CMakeLists.txt
- PhysicsAnalysis/RingerSelectorTools/RingerSelectorTools/tools/onnx/RingerSelector.h
- PhysicsAnalysis/RingerSelectorTools/Root/tools/onnx/RingerSelector.cxx
added Analysis CaloRinger main labels
CI Result FAILURE (hash e97e89fc)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1802]This merge request affects 1 package:
- PhysicsAnalysis/RingerSelectorTools
This merge request affects 3 files:
- PhysicsAnalysis/RingerSelectorTools/CMakeLists.txt
- PhysicsAnalysis/RingerSelectorTools/RingerSelectorTools/tools/onnx/RingerSelector.h
- PhysicsAnalysis/RingerSelectorTools/Root/tools/onnx/RingerSelector.cxx
CI Result SUCCESS (hash 49ff4908)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1846]added 75 commits
-
49ff4908...4d816fd9 - 74 commits from branch
atlas:main
- d8aff4e3 - Merge branch athena:main into rename_barcode
-
49ff4908...4d816fd9 - 74 commits from branch
This merge request affects 1 package:
- PhysicsAnalysis/RingerSelectorTools
This merge request affects 3 files:
- PhysicsAnalysis/RingerSelectorTools/CMakeLists.txt
- PhysicsAnalysis/RingerSelectorTools/RingerSelectorTools/tools/onnx/RingerSelector.h
- PhysicsAnalysis/RingerSelectorTools/Root/tools/onnx/RingerSelector.cxx
added review-pending-level-1 label
CI Result SUCCESS (hash d8aff4e3)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1883]added 2 commits
- 7a912915 - Rename
- b4e1ee54 - Merge branch 'rename_barcode' of ssh://gitlab.cern.ch:7999/averbyts/athena into rename_barcode
This merge request affects 1 package:
- PhysicsAnalysis/RingerSelectorTools
This merge request affects 3 files:
- PhysicsAnalysis/RingerSelectorTools/CMakeLists.txt
- PhysicsAnalysis/RingerSelectorTools/RingerSelectorTools/tools/onnx/RingerSelector.h
- PhysicsAnalysis/RingerSelectorTools/Root/tools/onnx/RingerSelector.cxx
CI Result SUCCESS (hash b4e1ee54)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1917]