Skip to content

Updated InDetTrackSelectionToolWrapper config for derivations

Thomas Strebler requested to merge tstreble/athena:TrackSelCfg into main

Follow up to !67314 (merged) as it turns out several derivation configs are actually configuring the cut level of the InDetTrackSelectionToolWrapper behind its back.

Introduces CutLevel property in the config to make this explicit (and drop ContainerName since its default value is InDetTrackParticles anyway). Also sets centrally maxAbsEta property, to increase it to eta=4 for Run 4 configs.

Fixes ART failures in JETM derivations in particular https://bigpanda.cern.ch//media/filebrowser/2b72f15b-d119-4cff-933f-32d20cd76c99/group.art/tarball_PandaJob_6035138162_UKI-LT2-RHUL_VP/log.Derivation

03:01:51   File "/srv/workDir/runargs.Derivation.py", line 40, in <module>
03:01:51     fromRunArgs(runArgs)
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/DerivationFrameworkConfiguration/DerivationSkeleton.py", line 120, in fromRunArgs
03:01:51     cfg.merge(derivationConfig(flags))
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/DerivationFrameworkJetEtMiss/JETM10.py", line 55, in JETM10Cfg
03:01:51     acc.merge(JETM10KernelCfg(ConfigFlags, name="JETM10Kernel", StreamName = 'StreamDAOD_JETM10', TriggerListsHelper = JETM10TriggerListsHelper))
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/DerivationFrameworkJetEtMiss/JETM10.py", line 38, in JETM10KernelCfg
03:01:51     acc.merge(LooseMETTriggerDerivationKernelCfg(ConfigFlags, name="JETM10Kernel", skimmingTools = [skimmingTool], StreamName = 'StreamDAOD_JETM10'))
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 924, in merge
03:01:51     self.addPublicTool(pt) #Profit from deduplicaton here
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/AthenaConfiguration/ComponentAccumulator.py", line 634, in addPublicTool
03:01:51     deduplicate(newTool,self._publicTools)
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/AthenaConfiguration/Deduplication.py", line 31, in deduplicate
03:01:51     raiseWithCurrentContext(exception)
03:01:51   File "/cvmfs/atlas-nightlies.cern.ch/repo/sw/main_Athena_x86_64-el9-gcc13-opt/2023-11-27T2101/Athena/24.0.17/InstallArea/x86_64-el9-gcc13-opt/python/AthenaConfiguration/DebuggingContext.py", line 48, in raiseWithCurrentContext
03:01:51     raise type(exception)(str(exception) + '\nWith the context:\n{}'.format(Context.complete()) )
03:01:51 ValueError: conflicting settings for property CutLevel of InDetTrackSelectionTool_TightPrimary: cannot merge values 'Loose' and 'TightPrimary'

Merge request reports