AthenaAuditors: Fix cppcheck warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.AthenaAuditors-20231204 into main

Use splay_set::erase_and_dispose rather than doing the deletion separately; otherwise, cppcheck gets confused as to where the pointer's coming from.

Merge request reports