Skip to content

TriggerJobOpts: propagate LAr legacy flags to ConfigFlags in runHLT_standalone

Bertrand Martin Dit Latour requested to merge martindl/athena:main_LArFlagsFix into main

Hello,

When running RDOtoRDOTrigger with the legacy config, it seems that we do not set the LAr config flags correctly. In MC23, LAr flags are set by a preInclude, e.g. --preInclude "all:Campaigns.MC23a", calling Campaigns/share/MC23a.py, in turn calling LArConfiguration/share/LArConfigRun3Old.py. The jobproperties legacy flags are configured, but not propagated to TriggerJobOpts/share/runHLT_standalone.py which rely on ConfigFlags. The mapping between legacy and config flags can be found in AthenaConfiguration/python/OldFlags2NewFlags.py. After adding the mapping to runHLT_standalone, we get the following changes for MC23:

  • flags.LAr.ROD.nSamples is now 4 instead of 5
  • flags.LAr.ROD.UseHighestGainAutoCorr is now True instead of False
  • flags.LAr.ROD.NumberOfCollisions is now 60 instead of 0

This bug is affecting the MC21a, MC23a and MC23c campaigns. Its impact is discussed in ATR-28590.

We don't expect the counts to change in the MC CI test, because the test doesn't specify a MC campaign in the preInclude...

The fix improves the agreement between CA and legacy configs (ATR-28470), the CA setup is not affected by the missing flag mapping.

Tagging @damazio and @dbakshig for HLT Calo. And @sshaw , @khoo , @wiedenma , @okuprash , @fwinkl , @tamartin for a second look (is it the appropriate place to do this mapping?).

Cheers, Bertrand

Edited by Bertrand Martin Dit Latour

Merge request reports