Skip to content
Snippets Groups Projects

Add functionality for DetectorType to ITk Strips

Merged Nicholas Styles requested to merge nstyles/athena:detTypeHandlingStrip into main
All threads resolved!

In ReadoutGeometryBase, we define a DetectorType enum, giving details about the detector region. This is already in use for the ITkPixel, HGTD and PLR, but not ITkStrip since the information provided can easily be retrieved from the Identifier already. However, in the interests of consistency across the Phase 2 detectors, this is added here for ITkStrip too.

Currently this will trigger a WARNING if detector description files try to set the type to anything but what would be expected from the code path, but in future if more fine distinctions are to be added to the DetectorType, the checks which currently trigger a WARNING message could be relaxed/removed.

FYI @sroe

Edited by Nicholas Styles

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicholas Styles resolved all threads

    resolved all threads

  • Nicholas Styles added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetDetDescr/SCT_ReadoutGeometry
    • InnerDetector/InDetDetDescr/StripGeoModelXml

    Affected files list will not be printed in this case

    Adding @sroe ,@goetz as watchers

  • :white_check_mark: CI Result SUCCESS (hash f508dd7a)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3047]

  • Looks good to me, approving request.

    Cheers, Lucy (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit f3d6991b

    mentioned in commit f3d6991b

  • Please register or sign in to reply
    Loading