Add functionality for DetectorType to ITk Strips
In ReadoutGeometryBase
, we define a DetectorType
enum, giving details about the detector region. This is already in use for the ITkPixel
, HGTD
and PLR
, but not ITkStrip
since the information provided can easily be retrieved from the Identifier already. However, in the interests of consistency across the Phase 2 detectors, this is added here for ITkStrip
too.
Currently this will trigger a WARNING
if detector description files try to set the type to anything but what would be expected from the code path, but in future if more fine distinctions are to be added to the DetectorType
, the checks which currently trigger a WARNING
message could be relaxed/removed.
FYI @sroe
Merge request reports
Activity
added ITk InnerDetector main review-pending-level-1 labels
CI Result SUCCESS (hash 9383f480)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2989]- Resolved by Nicholas Styles
CI Result SUCCESS (hash f508dd7a)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3047]added review-approved label and removed review-pending-level-1 label
mentioned in commit f3d6991b