Skip to content
Snippets Groups Projects

RoadPredictor tool for Trigger Phase II ITk tracking, EFTRACK-142

Merged Dmitry Emeliyanov requested to merge demelian/athena:trig-ftf-itk-det-road-tool into main
All threads resolved!

added a new tool prototype, development for ITk Phase II trigger tracking as described in EFTRACK-142, no changes in test output expected.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lucy Lewitt
  • Lucy Lewitt
  • Some very minor code formatting issues mentioned in threads but otherwise looks good.

    Cheers, Lucy (L1)

  • added review-approved label and removed review-pending-level-1 label

  • added 1 commit

    • 96806096 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • b4bb1419 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigTools/TrigInDetToolInterfaces
    • Trigger/TrigTools/TrigInDetTrackFitter

    Affected files list will not be printed in this case

    Adding @sutt ,@bkerridg ,@nagano ,@keli as watchers

  • Dmitry Emeliyanov resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 2 packages:

    • Trigger/TrigTools/TrigInDetToolInterfaces
    • Trigger/TrigTools/TrigInDetTrackFitter

    Affected files list will not be printed in this case

    Adding @sutt ,@bkerridg ,@keli ,@nagano as watchers

  • :white_check_mark: CI Result SUCCESS (hash 96806096)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3052]

  • :white_check_mark: CI Result SUCCESS (hash b4bb1419)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3053]

  • Thomas Strebler
  • Thomas Strebler
  • I've just shared a few extra comments worth to consider.

    Best, Thomas - L2

  • added 1 commit

    • 9b47922e - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 1 commit

    • 6d475441 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • Trigger/TrigTools/TrigInDetToolInterfaces
    • Trigger/TrigTools/TrigInDetTrackFitter

    Affected files list will not be printed in this case

    Adding @keli ,@sutt ,@bkerridg ,@nagano as watchers

  • This merge request affects 2 packages:

    • Trigger/TrigTools/TrigInDetToolInterfaces
    • Trigger/TrigTools/TrigInDetTrackFitter

    Affected files list will not be printed in this case

    Adding @keli ,@sutt ,@nagano ,@bkerridg as watchers

  • Dmitry Emeliyanov resolved all threads

    resolved all threads

  • :pencil: :scissors: CI integration tests for projects Athena are cancelled because of compilation error(s)

  • :x: CI Result FAILURE (hash 9b47922e)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :o:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3104]

  • :white_check_mark: CI Result SUCCESS (hash 6d475441)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3105]

  • The changes have been vetted already and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit 6663b17d

    mentioned in commit 6663b17d

  • Please register or sign in to reply
    Loading