Skip to content

[ATR-28716] Refactor Calo GPU flags

Tim Martin requested to merge tamartin/athena:gpuFlagRefactor into main

Hello @damazio, @dossantn

Please could you check this proposed refactor of the Calo GPU flags.

  • Moved these to be a standard lazy-loaded flag subcategory.
  • Added an explicit "doGPU" subflag which defaults to False. Code which is configuring based on the flag container should check this instead of doing a hasFlag check (as flags should always be available in builds which include the package which supplies the module which defines the flags, in this case it is just the Athena build I think which builds the Calorimeter/CaloRecGPU package)
  • Moved non-trivial flag defaults to be computed via lambda functions, these will resolve when the flag is queried on the locked collection.
  • Checked that flags are not used before the container is locked.

If there are additional tests I can run beyond ctest without a GPU, let me know what these are too!

Merge request reports