[ATR-28536][ATR-28717][ATR-28782] Working towards a trigger EDM refactor and integrating R4 into the EDM (part B)
Follows from !68370 (merged)
cc @cantel, @okuprash, @wiedenma, @fwinkl
Here in part B, I aim to make the following changes
- Change the signature of
getTriggerEDMListto require the config flags (but make it such that it doesn't crash if you supplyNonefor some e.g. standalone test use cases). Update all clients. - Introduce a new function,
getRawTriggerEDMListwhich takesflags. Every user of theTriggerEDMRun3.TriggerHLTListRun3should obtain this list via this function such that every client gets a consistent copy. Updated all clients. Flags can beNoneand the year can be specified explicitly instead, good for unit tests. - Mark the private functions inside
TriggerEDMwith an initial underscore. - Removed unused functions inside
TriggerEDM. - Move the
addExtraCollectionsToEDMListfunction from theTriggerEDMRun3file to theTriggerEDMfile. - Re-work the
addExtraCollectionsToEDMListfn to extend its functionality to adding new targets as well as new Aux (and completely new items). Give it unit tests. - Add a unit test to make sure that
allowTruncationitems are only at the end of the EDM list
To follow in the next part:
- Attempt to refactor
addHLTNavigationToEDMListto be called consistently (hard...) - Add caching to the
getRawTriggerEDMListfunction. - Make it harder to obtain
TriggerEDMRun3.TriggerHLTListRun3without going viagetRawTriggerEDMList(flags, 3), maybe wrap this list in a simple class. - Connect up the Run 4 EDM file
Edited by Tim Martin