Skip to content

Fix correlated smearing bug in JER in JetUncertainties in 22.0

Christopher Young requested to merge cyoung/athena:22.0-JERbug into 22.0-mc20

This is a copy of !68331 (merged) but in 22.0 (if 22.0 is closed then we can probably reject this MR)

@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data it is more correct to use the max(MC,data) resolution. This was not anticipated when the tool was originally written but results in very small changes. Finally advanced users can set the seed themselves, but this currently set the seed the same for all jets which is not a usual use-case so this has also been modified.

Merge request reports