Skip to content

Fix correlated smearing bug in JER in JetUncertainties in 24.0 and main

Christopher Young requested to merge cyoung/athena:24.0-JERbug into 24.0

This is a copy of !68331 (merged) but in 24.0 and main

I want to target both 24.0 and main - currently labels only exist for alsoTargeting:master and not either main or 24.0

@markowen found that the JER was using the same seed for smearing jets as is done in JetCalibTools. This results in a correlated smearing and a large over-estimation of the uncertainty. Additionally, as most people use MC as pseudo-data it is more correct to use the max(MC,data) resolution. This was not anticipated when the tool was originally written but results in very small changes. Finally advanced users can set the seed themselves, but this currently set the seed the same for all jets which is not a usual use-case so this has also been modified.

Edited by Christopher Young

Merge request reports