Skip to content

IOVDbFolder: code refactoring

Vakhtang Tsulaia requested to merge tsulaia/athena:main-iovdbfolder-refactor into main

Some code refactoring of the IOVDbFolder class aimed to simplify the IOVDbFolder::loadCache() monster. For now, this is mostly moving the code around. The ultimate goals of this activity are to extend the CREST reading code by first adding support for crossing IOV boundaries, and then adding support for extensible folders.

In this MR:

  • The code for fetching CREST IOVs and turning open-ended IOVs into a set of non-overlapping IOVs was factored out into a separate private function
  • The CREST-related part of the IOVDbFolder::loadCache() was spread over two large chunks. These chunks have been consolidated in one place as an intermediate step for further refactoring
  • Introduced a new private function IOVDbFolder::dumpFile() to factor out the code which produces the "cool_dump" and "crest_dump" files. CC @mmineev and @aleksand to double-check that the new dumpFile() looks good.

To squash or not to squash the commits on this MR is left to the discretion of the RC (CC @tadej)

Merge request reports