Update main L1Calo_Phase1 monitoring script and add a test for it
The script we are using hasn't been updated for a while, so this is a push of the latest version that is working both online and offline at the moment. I've also added a short test for it so we can get some early warning of some things that may break it (not a comprehensive test though).
Closes ATR-28908.
Merge request reports
Activity
This merge request affects 1 package:
- Reconstruction/RecExample/RecExOnline
This merge request affects 3 files:
- Reconstruction/RecExample/RecExOnline/CMakeLists.txt
- Reconstruction/RecExample/RecExOnline/python/L1Calo_Phase1.py
- Reconstruction/RecExample/RecExOnline/share/RecExOnline_Partition_Online_L1Calo_Phase1.py
added 24.0 L1Calo Reconstruction review-pending-level-1 labels
CI Result FAILURE (hash 52ebcc1a)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5565] (remote access info)This merge request affects 1 package:
- Reconstruction/RecExample/RecExOnline
This merge request affects 3 files:
- Reconstruction/RecExample/RecExOnline/CMakeLists.txt
- Reconstruction/RecExample/RecExOnline/python/L1Calo_Phase1.py
- Reconstruction/RecExample/RecExOnline/share/RecExOnline_Partition_Online_L1Calo_Phase1.py
- Resolved by Sreelakshmi Sindhu
@will The CI test has failed. Can you please check this issue?
Cheers, Sreelakshmi(L1)
removed review-pending-level-1 label
added review-user-action-required label
CI Result SUCCESS (hash a1ab1314)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5577] (remote access info)removed review-user-action-required label
added review-approved label
Hello @will
Do we actually want to move this somewhere else?
RecExCommon
is in the process of being deleted - and this now actually looks to be fully CA based (rightfully so).I don't know if people are looking to imminently delete
RecExOnline
too, but I would imagine it is being discussed.Also - could you clean up a bit more - there is a lot of commented out code here, and it would be preferable to do a find-replace and change
ConfigFlags
toflags
to be consistent with other steering files.Finally could you move the file into
python
(preferably in some other package)?Thanks! Tim
added review-user-action-required label and removed review-approved label
added DQ Trigger review-pending-level-1 labels and removed review-user-action-required label
Thanks @will - looks better
CI Result FAILURE (hash 896176c4)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5606] (remote access info)