Skip to content

Remove use of Cluster Maker Tool in the Acts Pixel Clustering Tool

Carlo Varni requested to merge cvarni/athena:RemoveClusterMakerTool into main

This removes the need of the ClusterMakerTool in the PixelClusteringTool, since that was causing some un-necessary re-computations as @sabidi noticed. Indeed the idea was already to get rid of this tool to avoid that (@lgagnon), as we currently do for the strip clustering. I moved brought some of the code from the ClusterMakerTool inside the PixelClusteringTool, which can be revised in later stages.

Concerning the error strategy for the clusters @lgagnon I see that in Athena we are currently using strategy 1 for ACTS clusters, but there are uses (within Athena) of other strategies according to the run configuration (e.g. Cosmics). I'd suggest to keep the different implementations still in place (much easier to remove if not needed rather then add back if needed) and eventually re-discuss the cluster errors with @asalzbur, @ncalace and @cgrefe

@sabidi @ncalace this still does not address the fact we are not setting cluster's identifiers. Out of scope here, but has to be addressed at some point

Merge request reports