Skip to content

Simplifying DumpGeo, merging GeoExporter into DumpGeo, removing legacy configuration

Riccardo Maria Bianchi requested to merge rbianchi/athena:dumpgeo-new-cli-options into 24.0

This MR removes the GeoExporter package, merging its features into DumpGeo.

It also simplify DumpGeo itself, and it adds better safety check on user's inputs and better CLI options.

It also removes the legacy configuration.

DumpGeo gets the GeoModel tree from the GeoModelSvc inside the init() method; we do not do anything inside the execute() method. Thus, this MR also sets EvtMax to 0 when running DumpGeo interactively from the command line, so that only the Athena init step is run: the execute step is not triggered at all, and only the finalize step is run after init. (Thanks to @wlampl for the trick about setting EvtMax to 0 to achieve that!!)

Docs:

The MR also adds up-to-date information to the DumpGeo README file, documenting the use of the package with the latest updates in its user interface.

Another point: the removal of the GeoModelStandalone folder

This MR also moves DumpGeo out of GeoModelStandalone and removes the old parent folder.

Once upon a time, there was a GeoModelStandalone folder, which contained all the packages linked to the standalone version of GeoModel... However, over the years, some tools have been ported out of Athena, while others have been removed or merged into each other. Nowadays, there is only one package left, DumpGeo, and there's no point in having a folder for a single package.

Therefore, I moved that one folder up and removed the old parent folder.

NOTE: We need DumpGeo in 24.0 to debug the new Detector Description.

This MR is not output-changing, and no other Athena packages depend on DumpGeo, so it is completely safe to merge this MR into 24.0.

Edited by Riccardo Maria Bianchi

Merge request reports