Skip to content
Snippets Groups Projects

TrigEFMissingET CMake Fixes, main branch (2024.03.20.)

This is to undo a mistake introduced in !69806 (merged), and to fix another issue that was present in the code for even longer.

  • Since the shared library still needs ROOT, it has to be found explicitly by the code.
  • To make sure that the component library would see the LWTNN headers reliably, ${LWTNN_INCLUDE_DIRS} also needs to be used.

The reason I noticed these mistakes is because of the "serious warnings" in the latest nightlies.

https://bigpanda.cern.ch/nview/?nightly=main_Athena_x86_64-el9-gcc13-opt

image

Something that the shifters should've really picked up on... :frowning:

Merge request reports

Pipeline #7089642 passed

Pipeline passed for 3cc925d8 on akraszna:TrigEFMissingETCMakeFix-main-20240320

Approval is optional

Closed by Frank WinklmeierFrank Winklmeier 9 months ago (Mar 20, 2024 2:24pm UTC)

Merge details

  • The changes were not merged into main.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading