TrigEFMissingET CMake Fixes, main branch (2024.03.20.)
This is to undo a mistake introduced in !69806 (merged), and to fix another issue that was present in the code for even longer.
- Since the shared library still needs ROOT, it has to be found explicitly by the code.
- To make sure that the component library would see the LWTNN headers reliably,
${LWTNN_INCLUDE_DIRS}
also needs to be used.
The reason I noticed these mistakes is because of the "serious warnings" in the latest nightlies.
https://bigpanda.cern.ch/nview/?nightly=main_Athena_x86_64-el9-gcc13-opt
Something that the shifters should've really picked up on...
Merge request reports
Activity
added bugfix label
added Trigger main review-pending-level-1 labels
CI Result SUCCESS (hash 3cc925d8) Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6760] (remote access info) added review-approved label and removed review-pending-level-1 label
@akraszna the shifter (me) did pick up on this. And since all trigger changes should go to 24.0 it was fixed there in !69882 (merged) and it was just merged into main via !69965 (merged).