Externals Update, 24.0 branch (2024.04.22.)
Updated all projects to atlasexternals-2.1.16. The complete changeset wrt. atlasexternals-2.1.10 is (atlasexternals@2.1.10...2.1.16):
- Introduced
FindHighFive.cmake
for the correspondingly named external; - Changed External/onnxruntime to download a pre-built binary of ONNXRuntime instead of building it itself;
- Updated
Findonnxruntime.cmake
to handle the different header layout coming with the pre-built binaries;
- Updated
- Upgraded GeoModel to version
5.3.0
(no effect on 24.0); - Set CMP0069 to
NEW
, to allow for convenient link time optimizations in the ATLAS projects; - Upgraded Geant4 to version
10.6.3.13
; - Made it possible to turn on LTO for the Geant4 and VecGeom builds.
This all is mainly needed for ATLASSIM-6058, to speed up G4. But it shall also help with ATLINFR-5341 because of the ONNX updates.
The most controversial part, I believe, is that the MR switches off our GCC checkers. Since as we discussed in ATLASSIM-6058 with @ssnyder, that code doesn't work with LTO just yet. (But hopefully soon.) So for now I propose to turn it off for Athena-24.0. But I'm open to a discussion about this.
Merge request reports
Activity
This merge request affects 20 packages:
- Control/AthOnnx/AthOnnxComps
- Control/AthOnnx/AthOnnxInterfaces
- Control/AthOnnx/AthOnnxUtils
- Control/AthOnnxruntimeService
- Control/AthOnnxruntimeUtils
- Control/AthenaExamples/AthExOnnxRuntime
- InnerDetector/InDetGNNTracking
- PhysicsAnalysis/AnalysisCommon/ONNXUtils
- PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
- PhysicsAnalysis/JetTagging/JetTagPerformanceCalibration/xAODBTaggingEfficiency
- PhysicsAnalysis/RingerSelectorTools
- Projects/AnalysisBase
- Projects/AthAnalysis
- Projects/AthGeneration
- Projects/AthSimulation
- Projects/Athena
- Projects/DetCommon
- Projects/VP1Light
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
- Simulation/Overlay/TrackOverlay/TrackOverlayRec
Affected files list will not be printed in this case
Adding @sroe ,@gemmeren ,@krumnack ,@tadej ,@tkharlam ,@ssnyder ,@akraszna ,@lidiaz ,@maszyman ,@svanstro ,@zhangr ,@jchapman ,@jbeirer ,@ahaas ,@dguest ,@goetz ,@bdong ,@rbianchi ,@schaarsc as watchers
removed analysis-review-required label
added analysis-review-approved label
CI Result FAILURE (hash 7e1e2dab)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8402] (remote access info)added review-pending-level-2 label and removed review-pending-level-1 label
- Resolved by Frank Winklmeier
The test failure in AnalysisBase looks surprising.
@@ -1,273 +1,266 @@ EgEfficiencyCorr_testE... INFO Environment initialised for data access -EgEfficiencyCorr_testE...INFO Opening file: /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/ASG/DAOD_PHYS/p5169/mc20_13TeV.410470.PhPy8EG_A14_ttbar_hdamp258p75_nonallhad.deriv.DAOD_PHYS.e6337_s3681_r13167_p5169/DAOD_PHYS.29445530._000001.pool.root.1 -EgEfficiencyCorr_testE...INFO Number of available events to read in: 40000 +EgEfficiencyCorr_testE...INFO Opening file: /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/ASG/DAOD_PHYS/p5855/mc20_13TeV.410470.PhPy8EG_A14_ttbar_hdamp258p75_nonallhad.deriv.DAOD_PHYS.e6337_s3681_r13167_p5855/DAOD_PHYS.34865530._000740.pool.root.1 +EgEfficiencyCorr_testE...INFO Number of available events to read in: 30000 EgEfficiencyCorr_testE...INFO Number actual events to read in: 40
@krumnack, could you look after this one?
Note that AnalysisBase is only built by this MR because I updated
AnalysisBase/externals.txt
. Maybe I should not have done that. Still, it may not be the worst idea to have all AB unit tests working in this branch as well. Just in case...
- Resolved by John Derek Chapman
Concerning the disabling of gcchecker, I am very uneasy, i.e. since Scott said that fixing this may take a while. This means that any C++ updates in 24.0 are not being checked and we will only see the warnings popping up in main which could cause quite a bit of extra work for the RC (it may even mean we introduce thread-unsafe code into our production branch).
How urgent is the LTO update? Can we postpone/decouple this?
added review-user-action-required label
- Resolved by Attila Krasznahorkay
@akraszna either the MR title is wrong or the target branch...
mentioned in merge request !70807 (merged)