Skip to content
Snippets Groups Projects

Fixing bug in reading ITkPRDToTrackMap and saving SiSPSeededTracks for other ITk extensions

Merged Noemi Calace requested to merge ncalace/athena:feat-add-cluster-truth-acts-workflow into main

When trying to save the SiSPSeededTrack collection in the actsValidateTracks tracking pass, a few bugs on the configuration of the tool have been found.

FYI: @tstreble @cvarni @goetz @adye @astefl

The command I have used is the following:

Reco_tf.py --CA \
--steering doRAWtoALL \
--preInclude "InDetConfig.ConfigurationHelpers.OnlyTrackingPreInclude,ActsConfig.ActsCIFlags.actsValidateTracksFlags" \
--preExec "ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.doTruth=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True; ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True; ConfigFlags.Debug.DumpEvtStore=False" \
--inputRDOFile $RDO \
--outputAODFile $AOD \
--maxEvents $NumberOfEvents

This allows to store SiSPSeededTracksActsValidateTracksTrackParticles (ConfigFlags.Tracking.doStoreSiSPSeededTracks=True; ConfigFlags.Tracking.ITkActsValidateTracksPass.storeSiSPSeededTracks=True) as well as truth information on ITk pixel and strip clusters (ConfigFlags.Tracking.writeExtendedSi_PRDInfo=True).

Once these information is available in the AOD, you can easily produce technical efficiency plots and investigate the aforementioned track collection:

runIDPVM.py --filesInput $AOD --outputFile $IDPVM \
--validateExtraTrackCollections 'SiSPSeededTracksActsValidateTracksTrackParticles' --doTechnicalEfficiency --doExpertPlots

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Noemi Calace added 1 commit

    added 1 commit

    Compare with previous version

  • Noemi Calace resolved all threads

    resolved all threads

  • added Tracking label

  • This merge request affects 4 packages:

    • InnerDetector/InDetConfig
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
    • Tracking/Acts/ActsTruth
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @jburzyns ,@pagessin ,@jojungge ,@cvarni ,@tbold ,@dshope ,@sroe ,@toyamaza ,@emmat ,@goetz ,@jcatmore ,@tstreble as watchers

  • added ACTS label

  • CI Result SUCCESS (hash 0f4bf43b)

    Athena AthSimulation
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8776] (remote access info)

  • CI Result FAILURE (hash 5ef688ca)

    Athena AthSimulation
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 8782] (remote access info)

    • Resolved by Carlo Varni

      Hi @ncalace. There are some errors and warnings here, such as this one:

      AWtoALL 16:28:25 PrecedenceSvc                                                0   ERROR   Strongly connected components found in DF realm:
      RAWtoALL 16:28:25  o [lowlink:39] | ITkAmbiguityScoreConversion | ITkSiSpTrackFinderROIConvConversion |
      RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize service "PrecedenceSvc"
      RAWtoALL 16:28:25 AvalancheSchedulerSvc                                        0   FATAL Error retrieving PrecedenceSvc
      RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize service "AvalancheSchedulerSvc"
      RAWtoALL 16:28:25 AthenaHiveEventLoopMgr                                       0   FATAL Error retrieving SchedulerSvc interface ISchedulerSvc.
      RAWtoALL 16:28:25 ServiceManager                                               0   ERROR Unable to initialize Service: AthenaHiveEventLoopMgr
      RAWtoALL 16:28:25 Py:ComponentAccumulator   ERROR Failed to initialize AppMgr

      Can these be looked into?

      -- James for L1

  • @ncalace can you rebase on top of !71002 (merged) ? I've clarified the configs of the PRDtoTrackMap there.

  • This has now taken merge conflicts (as expected). @ncalace can you address these?

  • Noemi Calace added 155 commits

    added 155 commits

    • 5ef688ca...a2f5545c - 153 commits from branch atlas:main
    • 9df85954 - fixing bug in reading ITkPRDToTrackMap and saving SiSPSeededTracks for other ITk extensions
    • 855eb5e1 - resolving

    Compare with previous version

  • This merge request affects 4 packages:

    • InnerDetector/InDetConfig
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
    • Tracking/Acts/ActsTruth
    • Tracking/TrkConfig

    Affected files list will not be printed in this case

    Adding @jburzyns ,@tstreble ,@goetz ,@sroe ,@jojungge ,@pagessin ,@cvarni ,@toyamaza ,@jcatmore ,@emmat ,@dshope ,@tbold as watchers

  • Carlo Varni resolved all threads

    resolved all threads

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading