FPGATrackSimAlgorithms: Fix cppcheck 2.14 warnings.
Copying values in range-for. Potential use of invalidated iterators. Prefer range-for. sprintf format/argument match. sprintf buffer size. Pass objects by const reference, not by value. Prefer returning const references to members rather than copies.