Skip to content
Snippets Groups Projects

InDetTrackPerfMon: Adding TrackAnalysisPlotsMgr and TrackParametersPlots

Merged Marco Aparo requested to merge maparo/athena:maparo-main-IDTPM-v1.9.1 into main

Third iteration of the MR after !71136 (merged) and !71213 (merged). This MR adds the final utilities needed to create plots in this package:

  • TrackAnalysisPlotsMgr: further (and final) wrapper around the PlotMgr class, which integrates the "TrackAnalysis" infrastructure thus allowing its inclusion in the workflow.
  • TrackParametersPlots: first plots category class addressing the basic track parameters variables (pT, eta, etc.). These plot category classes are placed in the src/plots sub-directory for logistical reasons (since the number of categories is expected to grow significantly), to separate them from the main components of this package, and to allow for better documentation (dedicated README).

The (python) configuration for the various plotting utilities is also addressed here.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetTrackPerfMon

    This merge request affects 25 files:

    • InnerDetector/InDetValidation/InDetTrackPerfMon/CMakeLists.txt
    • InnerDetector/InDetValidation/InDetTrackPerfMon/InDetTrackPerfMon/IPlotsDefReadTool.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/InDetTrackPerfMon/IPlotsDefinitionSvc.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/data/PlotsDefCommonValues.json
    • InnerDetector/InDetValidation/InDetTrackPerfMon/data/PlotsDefFileList_default.txt
    • InnerDetector/InDetValidation/InDetTrackPerfMon/data/TrkParamPlotsDef.json
    • InnerDetector/InDetValidation/InDetTrackPerfMon/data/trkAnaConfigs_example.json
    • InnerDetector/InDetValidation/InDetTrackPerfMon/python/ConfigUtils.py
    • InnerDetector/InDetValidation/InDetTrackPerfMon/python/InDetTrackPerfMonConfig.py
    • InnerDetector/InDetValidation/InDetTrackPerfMon/scripts/runIDTPM.py
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/IPlotsDefReadTool.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/InDetTrackPerfMonTool.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/InDetTrackPerfMonTool.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/JsonPlotsDefReadTool.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/PlotMgr.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/PlotMgr.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/PlotsDefinitionSvc.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/PlotsDefinitionSvc.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisDefinitionSvc.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/TrackAnalysisPlotsMgr.h
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/components/InDetTrackPerfMon_entries.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/plots/README.md
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/plots/TrackParametersPlots.cxx
    • InnerDetector/InDetValidation/InDetTrackPerfMon/src/plots/TrackParametersPlots.h

    Adding @cvarni ,@maparo ,@goetz ,@sroe as watchers

  • CI Result SUCCESS (hash 31a29a3f)

    Athena
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 9587] (remote access info)

  • Changes look good - approving

    L1 shifter

  • added review-approved label and removed review-pending-level-1 label

  • Tadej Novak mentioned in commit 346f8244

    mentioned in commit 346f8244

  • merged

  • Marco Aparo mentioned in merge request !71456 (merged)

    mentioned in merge request !71456 (merged)

Please register or sign in to reply
Loading