Skip to content

Fix edge case indexing for the sTGC pads

Matous Vozak requested to merge mvozak/athena:fix-stgcpad-design into 24.0

This MR addresses the ATLASRECTS-7979.

After adding some printouts the problem seems to always happen for: Pad identifier padEta1 padPhi: 1 ml: 2 gasgap: 1 channel: 1 channeltype: 0

The issue is the edge case. For this, the height (y1) calculated based on this code is 0 (yCutout = 0 and then 0.5 size == pos.y() ). Furthermore, this case is not treated by any of the conditions in the code.

There were two proposals to fix this:

1] Reject these cases by including y=0 in this condition

2] Include these cases by offsetting padEta to 1. This is the one we opted to go for.

Mat

Tagging: @pscholer, @jojungge

Here are the comparisons on 150k events for the patched and unpatched 24.0.45 version AllPerigeeChecks.pdf

Mostly hits seem consistent. I see small subpercent changes in the middle hits, in particular there seem to be 0.7% increase for nMidHits=0 and slight decrease for nMidHits=3 and 7. Also there is about 3% increase on the middleHoles=2. This might be cause by the bad muons or small instabilities in the fit.

Edited by Matous Vozak

Merge request reports