Draft: FPE protection correction

FPE in ATR-28243 appeared again in ART. This merge request hopefully is the final correction.

added 140 commits

• 7f04a9f5...dcf50b98 - 139 commits from branch atlas:24.0
• 4a1594c0 - Merge branch '24.0' into 'Fix_spurious_FPE'

Compare with previous version

This merge request affects 1 package:

• Tracking/TrkVertexFitter/TrkVKalVrtCore

This merge request affects 1 file:

• Tracking/TrkVertexFitter/TrkVKalVrtCore/src/cfMassErr.cxx

added 24.0 Tracking review-pending-level-1 labels

added 1 commit

• c8629bca - Revert "Merge branch '24.0' into 'Fix_spurious_FPE'"

Compare with previous version

This merge request affects 88 packages:

• AtlasTest/TestTools
• Calorimeter/CaloDetDescr
• Control/AthenaConfiguration
• DataQuality/DataQualityConfigurations
• DataQuality/DataQualityUtils
• Database/AthenaPOOL/OutputStreamAthenaPool
• Database/TPTools
• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcNtuple
• Generators/EvgenJobTransforms
• InnerDetector/InDetCalibAlgs/InDetBeamSpotFinder
• InnerDetector/InDetConfig
• InnerDetector/InDetEventCnv/ITkPixelByteStreamCnv
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetEventCnv/SCT_RawDataByteStreamCnv
• InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv
• InnerDetector/InDetMonitoring/InDetAlignmentMonitoringRun3
• InnerDetector/InDetMonitoring/TRTMonitoringRun3
• InnerDetector/InDetRecAlgs/SiSPSeededTrackFinder
• InnerDetector/InDetRecTools/InDetSVWithMuonTool
• InnerDetector/InDetRecTools/InDetTrackSelectionTool
• InnerDetector/InDetRecTools/InDetTrackSelectorTool
• InnerDetector/InDetRecTools/InDetVKalVxInJetTool
• InnerDetector/InDetRecTools/PixelToTPIDTool
• InnerDetector/InDetRecTools/SeedToTrackConversionTool
• InnerDetector/InDetRecTools/SiClusterOnTrackTool
• InnerDetector/InDetRecTools/SiClusterizationTool
• InnerDetector/InDetRecTools/SiCombinatorialTrackFinderTool_xk
• InnerDetector/InDetRecTools/SiDetElementsRoadTool_xk
• InnerDetector/InDetRecTools/TRT_DriftCircleOnTrackTool
• InnerDetector/InDetRecTools/TRT_DriftCircleTool
• InnerDetector/InDetRecTools/TRT_DriftFunctionTool
• InnerDetector/InDetRecTools/TRT_ElectronPidTools
• InnerDetector/InDetRecTools/TRT_SegmentToTrackTool
• InnerDetector/InDetRecTools/TRT_TrackHoleSearch
• InnerDetector/InDetRecTools/TRT_TrackSegmentsTool_xk
• InnerDetector/InDetRecTools/TrackVertexAssociationTool
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• LArCalorimeter/LArG4/LArG4FastSimulation
• MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator
• MuonSpectrometer/MuonCnv/MuonEventCnvTools
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonGeoModel
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools
• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants
• PhysicsAnalysis/MCTruthClassifier
• PhysicsAnalysis/PATJobTransforms
• Projects/AthSimulation
• Projects/Athena
• Projects/DetCommon
• Projects/VP1Light
• Reconstruction/MissingETMonitoring
• Reconstruction/RecJobTransforms
• Reconstruction/RecoTools/TrackToCalo
• Reconstruction/egamma/egammaAlgs
• Reconstruction/egamma/egammaConfig
• Reconstruction/egamma/egammaTools
• Reconstruction/egamma/egammaTrackTools
• Reconstruction/egamma/egammaValidation
• Simulation/SimuJobTransforms
• TileCalorimeter/TileMonitoring
• TileCalorimeter/TileTBRec
• Tools/PyJobTransforms
• Tracking/TrkConfig
• Tracking/TrkExtrapolation/TrkExEngine
• Tracking/TrkExtrapolation/TrkExTools
• Tracking/TrkFitter/TrkDistributedKalmanFilter
• Tracking/TrkFitter/TrkGaussianSumFilter
• Tracking/TrkFitter/TrkiPatFitter
• Tracking/TrkTools/TrkParticleCreator
• Tracking/TrkTools/TrkTrackSummaryTool
• Tracking/TrkVertexFitter/TrkVKalVrtCore
• Tracking/TrkVertexFitter/TrkVertexWeightCalculators
• Trigger/TrigHypothesis/TrigBphysHypo
• Trigger/TrigHypothesis/TrigHIHypo
• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigMonitoring/TrigHLTMonitoring
• Trigger/TrigMonitoring/TrigMETMonitoring
• Trigger/TrigMonitoring/TrigTauMonitoring
• Trigger/TrigTools/TrigInDetConfig
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigInDetValidation
• Trigger/TrigValidation/TrigP1Test
• Trigger/TrigValidation/TrigValTools
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT
• graphics/JiveXML

Affected files list will not be printed in this case

Adding @fpastore ,@rbianchi ,@peter ,@bkerridg ,@stavrop ,@jbeaucam ,@harkusha ,@goetz ,@amete ,@ademaria ,@shanisch ,@lgagnon ,@abarton ,@slai ,@rosati ,@calfayan ,@valentem ,@gipezzul ,@jajimene ,@aporeba ,@lidiaz ,@ssnyder ,@okumura ,@cgrefe ,@lyubushk ,@miochoa ,@jlieberm ,@martis ,@sutt ,@ibragimo ,@iriu ,@lshan ,@kluit ,@solodkov ,@vmartin ,@battagl ,@nagano ,@pavol ,@akraszna ,@iouri ,@mvozak ,@zmarshal ,@stelzer ,@jodafons ,@fernando ,@fwinkl ,@dbakshig ,@maszyman ,@pop ,@carquin ,@keli ,@ayana ,@jchapman ,@tstreble ,@efurtado ,@cantel ,@mverissi ,@mnowak ,@dshope ,@sroe ,@jojungge ,@salderwe ,@martindl ,@khamano ,@stsuno ,@gavrilen ,@apsallid ,@eegidiop ,@ggonella ,@jburzyns ,@hartj ,@pscholer ,@ebergeas ,@gemmeren as watchers

added Analysis BTagging Build Calorimeter Core DQ Database Derivation Egamma EventDisplay ForwardDetectors Generators ITk InnerDetector JetEtmiss L1Calo LAr MuonSpectrometer PhysValidation Reconstruction Simulation Tau Test Tile Tools Trigger TriggerID TriggerJet TriggerMenu analysis-review-required changes-trigger-counts full-unit-tests labels

WARNING: big files (>100K) are found in the changeset

116K in file DataQuality/DataQualityConfigurations/config/MuonCombined/collisions_run.config

384K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

392K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

164K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

112K in file Tools/PyJobTransforms/python/trfExe.py

176K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/MC_pp_run3_v1.py

132K in file InnerDetector/InDetCalibAlgs/InDetBeamSpotFinder/rootScripts/BeamspotCutEvaluation/VtxNtuple.h

140K in file InnerDetector/InDetMonitoring/TRTMonitoringRun3/src/TRTMonitoringRun3RAW_Alg.cxx

568K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

148K in file TileCalorimeter/TileTBRec/src/TileTBAANtuple.cxx

marked this merge request as draft

closed

@vkost If we use the methods here to print out debug information https://en.cppreference.com/w/cpp/numeric/fenv/fetestexcept . Will it help get to the bottom of the problem?

CI Result SUCCESS (hash 4a1594c0)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11066] (remote access info)

CI Result SUCCESS (hash c8629bca)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 11067] (remote access info)