AthenaCommon: fix AlgSequence/AthSequencer ambiguities
This fixes a very old issue related to legacy job options, which I came across again when doing some other unrelated cleanups:
>>> AlgSequence()
<AthSequencer/TopAlg at 0x7feebbc65360>
>>> AthSequencer("TopAlg")
<AthSequencer/TopAlg at 0x7feebbc65e50>
The fact that we are getting two separate instances is not what the user would expect. Change the AlgSequence
from a class deriving from AthSequencer
to a function. This ensures that the above two calls return the same instance.
While this code is likely not going to be used much anymore, I figured we may as well fix it.