VP1Base: Fix cppcheck 2.14 warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.VP1Base-20240614 into main

Copying value in range-for. Pass containers by const reference, not by value. Prefer returning const references to members rather than copies.

Merge request reports