Cleanup and modernize EvtIdModifierSvc
Modernize the EvtIdModifierSvc
to use c++17/20 features. The only functional change is an update to IEvtIdModifierSvc::modify_evtid
API. The first argument is now a reference instead of a reference to pointer which was unnecessary as the pointer itself is not modified. Also, run clang-format on these files.