Skip to content

Fix asserts, clang compilation, and actually apply an existing post-selection calibration

Goetz Gaycken requested to merge goetz/athena:main_acts_measurement_selector_fix_asserts_and_clang_compilation into main

Fixes for the newly added MeasurementSelector for the Acts chain (MR !72610 (merged))

  • If there is a calibration that should be applied after the measurement selection then apply it also in the code path which allows for a full calibration during the measurement selection (in the default configuration the calibration is applied during the measurement selection, i.e. no impact to the default configuration)

  • Fix problems when compiling with clang

    • added missing template keywords
    • specify template parameters which clang does not deduce
    • fix warnings concerning unused captures where the capture is only used in an constexpr-optional codepath
    • clang does not treat a static constexpr called via obj.method() as a constexpr.

  • Fix assert statements which should fix the debug build.

Edited by Goetz Gaycken

Merge request reports