Skip to content

MuonR4 - GeometryCnv rename alg & fix discrepancy in translation of legacy BI-RPC

Johannes Junggeburth requested to merge jojungge/athena:BIRpcLegacyFix into main

Fix conversion of the BI-Rpc into the legacy format. In the new geometry, they're residing underneath a new station while in the legacy EDM, they need to put somehow underneath the Mdt station with the same stationName, stationEta, stationPhi. The Run 4 layout conversion test (cf. !73381) still fails because of some inconsistencies in the readout parameters.

The last strip is very likely outside the trapezoid boundaries and hence the readout geometry places it into the centre of the gasGap. @pnswallow may I ask you to double check the BIL -1 stations?

Invalid strip position 16 
Strip -- number: 16, pitch: 21.81, width: 19.81, Dimension  -- width x height [mm]: 180 x 911/911 [mm], position first strip (-128.5, 0.0) *** Trapezoid edges (-180.0, -911.0) - (180.0, -911.0) --- (-180.0, 911.0) - (180.0, 911.0)
MuonDetectorManagerCondAlg                             0     0   ERROR Mismatch in strip positions RPC BIL eta -1 phi  5 dbR 1 dbZ 1 dbPhi 1 gap 1 eta channel 16 ref: (-5711.2050, 0.0000, -750.0000) test: (-5711.2050, 0.0000, -948.6950) local coordinates -- ref: (0.0000, 0.0000, 0.0000) test: (198.6950, 0.0000, 0.0000)
MuonDetectorManagerCondAlg                             0     0   ERROR MuonGeometryCnv/src/ReadoutGeomCnvAlg.cxx:361 (StatusCode MuonGMR4::ReadoutGeomCnvAlg::buildRpc(const ActsGeometryContext&, ConstructionCache&) const): code FAILURE: dumpAndCompare(gctx, *copyMe, *newElement)
MuonDetectorManagerCondAlg                             0     0   ERROR MuonGeometryCnv/src/ReadoutGeomCnvAlg.cxx:121 (StatusCode MuonGMR4::ReadoutGeomCnvAlg::execute(const EventContext&) const): code FAILURE: buildRpc(geoContext, cacheObj)
MuonDetectorManagerCondAlg                             0     0   ERROR Maximum number of errors ( 'ErrorMax':1) reached.

Tagging: @emoyse

Edited by Johannes Junggeburth

Merge request reports