Skip to content
Snippets Groups Projects

Muon trigger SF update

Merged Federica Fabbri requested to merge ffabbri/athena:ffabbri/UpdateRunNumber into main
All threads resolved!

The previous MR ( !73427 (merged)) for the update of Muon Trigger SF files missed an important part of the update on the run numbers for the different years.

Merge request reports

Pipeline #7880118 passed

Pipeline passed for 0fbcd52b on ffabbri:ffabbri/UpdateRunNumber

Merged by Tadej NovakTadej Novak 5 months ago (Aug 8, 2024 10:43am UTC)

Merge details

  • Changes merged into with aa717c4d.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just a minor format comment from the review, otherwise it looks good

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections

    This merge request affects 1 file:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonTriggerScaleFactors.cxx

    Adding @sangelid ,@nakahama ,@nicolaid ,@jojungge ,@vaustrup ,@apsallid as watchers

  • CI Result SUCCESS (hash 07ffbf98)

    Athena AnalysisBase AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14038] (remote access info)

  • Developer

    looks good, approving from AR side

  • mentioned in merge request !73427 (merged)

  • Tadej Novak resolved all threads

    resolved all threads

  • Tadej Novak added 1 commit

    added 1 commit

    • 0fbcd52b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections

    This merge request affects 1 file:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections/Root/MuonTriggerScaleFactors.cxx

    Adding @sangelid ,@vaustrup ,@jojungge ,@nicolaid ,@apsallid ,@nakahama as watchers

  • CI Result SUCCESS (hash 0fbcd52b)

    Athena AnalysisBase AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14067] (remote access info)

  • Maciej Pawel Szymanski
  • Maciej Pawel Szymanski
  • Thanks, just leaving two minor comments. Feel free to ignore them for now, and postpone for future MRs.

    • Resolved by Michael Holzbock

      Hmm, there might be a good chance that Federica is on vacation currently; it would be fantastic to have this MR in the release to be built this week so we can finally use the muon trigger SFs for 2023. As the open threads are minor and only suggestions for small code improvements: any objections if we close them for now and move on?

  • Michael Holzbock resolved all threads

    resolved all threads

  • merged

  • Tadej Novak mentioned in commit aa717c4d

    mentioned in commit aa717c4d

  • Hi, sorry I missed the notification! I am here I can make the change now

  • OK, please open a separate MR.

  • Please register or sign in to reply
    Loading