Skip to content

AFT-726: enable defaults for GN2v01 zero-track jets

Dan Guest requested to merge dguest/athena:moredef into 24.0

Important Bits

The expected changes:

  • Nothing in taggers we currently use (DL1d, GN2v02, GN2X).
  • A few taggers we don't use (rnnip, dl1r, GN2v00) should disappear. This will require a reference file update.

Why I'm doing it:

  • We need this to update ONNX Runtime

Details

Technically this stops running GN2v01 on zero track jets, and inserts default values instead (which are the same values we'd get from GN2v01). Since we should keep ONNX Runtime in sync in 24.0 I'm pushing it into 24.0 as well.

These changes would have changed GN2v00 as well, so easier to just delete it and do some cleanup along the way.

We can't just use one set of default values to fix AFT-726, since the zero track outputs depend on which fold we're looking at. So I also had to add some flexibility.

Still to be done

Unfortunately I wasn't able to extract the information I'd need to enable this in the trigger as well. Instead I disabled this in the trigger, which also means we probably can't update ONNX Runtime in 24.0 for now. The trigger case is fixed in !73680 (merged), which includes everything here but hasn't passed CI tests. If !73680 (merged) does pass CI tests it should be merged instead of this.

To do here:

  • Add more flexibility to C++ code
  • Add these options to the python code
  • Insert the appropriate default values for each fold
  • Rebase on 24.0
  • Turn this thing on
Edited by Dan Guest

Merge request reports