Demote warning in MissingMassProb for tau_type=6
In analysis jobs running with the MMC 2016 tuning, we get a fair amount of warnings
DiTauMassTools WARNING ---- WARNING in MissingMassCalculator::dTheta3d_probabilityFast() ----
DiTauMassTools WARNING ..... wrong tau_type=6
DiTauMassTools WARNING ..... returning prob=0.000000
DiTauMassTools WARNING ____________________________________________________________
Based on previous discussions, it was suggested to silence the warning
Merge request reports
Activity
added Tau label
@ademaria I think you had also mentioned the possibility of resetting the type in https://gitlab.cern.ch/atlas/athena/-/blob/main/PhysicsAnalysis/TauID/DiTauMassTools/Root/HelperFunctions.cxx?ref_type=heads#L164
Would that be a preferred option? Shall this be set to 5 in case the DM is not set?
mentioned in issue easyjet/easyjet#298 (closed)
- Resolved by Thomas Strebler
Hello @tstreble, I think it's better to just silence the warning but not resetting the type, otherwise we will end with an add-hoc re-classification under the carpet which is not good for me. Just mentioning also that this warning should affect only the 2016 MMC tuning, not the 2019 one (looking in the code, I think the 2019 MMC tuning is passing from another part of the code)
added Analysis analysis-review-required main review-pending-level-1 labels
✅ CI Result SUCCESS (hash b1c38fb4)Athena AnalysisBase AthAnalysis externals ✅ ✅ ✅ cmake ✅ ✅ ✅ make ✅ ✅ ✅ tests ✅ ✅ ✅ Full details available on this CI monitor view. Check the JIRA CI status board for known problems
✅ Athena: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthAnalysis: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 14732] (remote access info)added review-approved label and removed review-pending-level-1 label
added analysis-review-approved label and removed analysis-review-required label
mentioned in commit 6cee7a2a