Fix MuonField Manager configurations

Fix EpsilonStep limits. The two values appear to have been set the wrong way around.

Jenkins please retry a build

This merge request affects 1 package:

• Simulation/G4Atlas/G4AtlasTools

This merge request affects 1 file:

• Simulation/G4Atlas/G4AtlasTools/python/G4FieldConfig.py

Adding @jchapman as watcher

added Simulation main labels

added Run2-FullSim-output-changed Run3-AF3-output-changed Run3-FullSim-output-changed Run3-HitsMerge-output-changed Run4-FullSim-output-changed Run4-MCReco-output-changed labels

CI Result FAILURE (hash c25e384c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 15034] (remote access info)

added bugfix label

As expected, this tweak changes the output. @mbandier, @schaarsc, should we just update the config in main? It is clearly a bug - predates the CA-migration. Do you want to validate the changes somehow first?

Hi John, yes, it would be good to have a look at some phys val plots to see the impact of this fix. I am not sure if a UI command is available in Geant4, otherwise we would need a private build for phys val.

Probably we can cook-up a postExec for PhysVal

Something like this perhaps:

--postExec 'detConstructionTool=cfg.getService("DetectorGeometrySvc").DetectorConstruction;detConstructionTool.FieldManagers["MuonsOnlyInCaloFieldManager"].MaximumEpsilonStep=0.000001;detConstructionTool.FieldManagers["MuonsOnlyInCaloFieldManager"].MinimumEpsilonStep=0.0000009;detConstructionTool.FieldManagers["MuonFieldManager"].MaximumEpsilonStep=0.000001;detConstructionTool.FieldManagers["MuonFieldManager"].MinimumEpsilonStep=0.0000009'

Hi @jchapman @mbandier is this MR is still relevant?

Best, Thomas - L2

I think this was waiting on ATLPHYSVAL-1113 - so is probably OK to mark as ready now. @mbandier do you agree?

Yes, we have seen in phys val that no significant statistical difference is observed. So we can proceed with this M. Thanks!

OK - I will rebase and mark as ready.

added 3493 commits

• c25e384c...c9706e27 - 3492 commits from branch atlas:main
• 422e5d9e - Fix MuonField Manager configurations

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Simulation/G4Atlas/G4AtlasTools

This merge request affects 1 file:

• Simulation/G4Atlas/G4AtlasTools/python/G4FieldConfig.py

Adding @jchapman as watcher

added review-pending-level-1 label

added offline-sw-review-approved label

CI Result FAILURE (hash 422e5d9e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added RC Attention Required label

The changes in output are expected from this bugfix. It should be OK to update the reference files and review the code changes in parallel.

Changes looks fine, approving from L1 side

removed review-pending-level-1 label

added review-approved label

added 1 commit

• c1820037 - Bumped version tags for simulation tests in References.py, and updated q447_AOD_digest.ref

Compare with previous version

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 3 packages:

• Simulation/G4Atlas/G4AtlasTools
• Tools/PROCTools
• Tools/WorkflowTestRunner

Affected files list will not be printed in this case

Adding @pagessin ,@jchapman as watchers

added Tools review-pending-level-1 labels and removed review-approved label

CI Result SUCCESS (hash c1820037)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 5b6c114e