MuonEventAthenaPool: Fix cppcheck 2.15 warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.MuonEventAthenaPool-20240913 into main

Prefer returning const references to members rather than copies. Side-effects in assert().

Merge request reports