Skip to content

FTAG NN config: make required arguments required

Dan Guest requested to merge dguest/athena:required into 24.0

Basic code quality change: rather than checking if arguments are set and throwing exceptions if not, just make them required arguments. Should change absolutely nothing. But:

  • I'd imagine this is easier for static analysis tools to work with,
  • It seems simpler, and
  • It will help us reason about the issue that @xju is seeing in atlasexternals!1143 (merged), which is super weird to me: how are we ever giving None as a jet collection?

Tagging @bdong, @robouque, @ligang.

Edited by Dan Guest

Merge request reports