Skip to content

Add L1 jet RoIs to default PHYS

William Keaton Balunas requested to merge wbalunas/athena:l1jets-240920 into main

!73334 (merged) added the option to include the "legacy" L1 Jet RoIs (needed by some analyses for trigger matching) to DAOD_PHYS. A proposal to enable this inclusion by default was presented at the 13 September AMG meeting and agreed by the group (tagging @gwatts & @ekourlit for reference). So, this MR removes the flag which was previously gating the inclusion of these objects and replaces it with a check on the data year/MC campaign (since this legacy L1 system was used for primary triggers in Run 2 and Run 3 up to 2023).

This MR intentionally does not affect PHYSLITE; further work is needed to investigate possible size reductions first.

This MR also adds the jFEX ("Phase-I") RoIs, which are the equivalent for 2024 onward but use a different EDM. Since definitive size estimates haven't been presented to AMG yet, this is behind a flag (False by default) for now, as the legacy ones were prior to this MR.

Edit: After some discussion it was decided to also enable this for the jFEX ("Phase-I") RoIs for 2024/mc23e onward. So, this includes a check on the year/campaign to decide which to use, and always stores the result.

Tagging @khoo and @tamartin - we may want to refactor some of this code in the near future (e.g. where we do the year check and slimming helper handling), but this is an effective and not-too-messy solution in the meantime so we've got something to work with.

@lshi might also be interested in this from the analysis side.

Edited by William Keaton Balunas

Merge request reports