ISF_FastCaloSimEvent: Fix cppcheck 2.15 warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.ISF_FastCaloSimEvent-20240920 into main

Prefer returning const references to members rather than copies. Copying value in range-for.

Merge request reports