Skip to content
Snippets Groups Projects

Add VeryLooseDNNnoCF97 electron WP

Merged Filip Nechansky requested to merge ATLAS-EGamma/athena:main-replace_dnn_loose into main

Adds new VeryLooseDNNnoCF97 WP and replaces LooseDNNnoCF in PHYSLITE as discussed in ATLASG-2789 . This MR targets the next PHYSLITE production so should be merged by 27/9.

Tagging @honguyen @mojeda @kristin @ludovica @ahabouel for e/y

As the variable in physlite is only replaced, the size will not change but still tagging @gwatts @ekourlit @emmat

Merge request reports

Pipeline #8214690 running

Pipeline running for f80e2cc9 on ATLAS-EGamma:main-replace_dnn_loose

Merged by Johannes ElmsheuserJohannes Elmsheuser 2 months ago (Sep 27, 2024 8:39am UTC)

Merge details

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :x: CI Result FAILURE (hash e73cfd87)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added 1 commit

    • 1e0ad356 - Fix typo in EGSelectorConfigurationMapping

    Compare with previous version

  • This merge request affects 4 packages:

    • PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
    • PhysicsAnalysis/ElectronPhotonID/ElectronPhotonSelectorTools

    Affected files list will not be printed in this case

    Adding @tadej ,@krumnack ,@emmat ,@zmarshal ,@dshope ,@jcatmore as watchers

  • :x: CI Result FAILURE (hash 1e0ad356)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • The changes look good to me from AR side

    Giovanni (AR)

  • added urgent label

    • Resolved by Thomas Strebler

      Hi @fnechans changes look good to me. Could you please resolve the open thread and the CI failure tests (see errors below) ? Thanks, L1 (Fábio).

      ERROR Py:diff-root ERROR the following variables exist only in the old file ! ERROR Py:diff-root ERROR - [ElectronsAuxDyn.DFCommonElectronsDNNLooseNoCF] ERROR Py:diff-root ERROR the following variables exist only in the new file ! ERROR Py:diff-root ERROR - [ElectronsAuxDyn.DFCommonElectronsDNNVeryLooseNoCF97]

      Edited by Fabio Lucio Lucio Alves
  • Thomas Strebler resolved all threads

    resolved all threads

  • Jenkins please retry a build

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading