MuonR4 Geoemetry - Chop the chamber into smaller volumes
In the MS tracking geometry building, all readout elements in a sector-layer have been put into single envelope volume. However, initial navigation tests showed that this might be too fat for the frustrum navigation --> chop the volume into smaller chunks
- The chamber is now restricted to the set of readoutelements belonging to the same muon station
- However, the sector envelope coordinate system is utterly useful in the pattern finding stage -> Introduce the
SpectrometerSector
which summarizes all chambers from a sector-layer and provides the same coordinate system as the MuonChamber before. - Adapt method naming of the
SpacePoint
,SegmentSeed
,Segment
ofchamber
->msSector
.
Merge request reports
Activity
This merge request affects 15 packages:
- MuonSpectrometer/MuonPhaseII/ActsMuonDetector
- MuonSpectrometer/MuonPhaseII/Event/MuonPatternEvent
- MuonSpectrometer/MuonPhaseII/Event/MuonSpacePoint
- MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonBucketDump
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonHitCsvDump
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelR4
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternRecognitionAlgs
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonSpacePointFormation
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonTruthAlgsR4
- MuonSpectrometer/MuonPhaseII/MuonValidation/MuonObjectMarker
- MuonSpectrometer/MuonPhaseII/MuonValidation/MuonPatternRecognitionTest
Affected files list will not be printed in this case
Adding @markowen ,@pscholer ,@jojungge ,@kluit ,@wleight ,@cvarni ,@toyamaza ,@stavrop ,@mvozak ,@apsallid ,@tbold ,@pagessin ,@ddicroce as watchers
added ACTS MuonSpectrometer Upgrade main review-pending-level-1 labels
CI Result FAILURE (hash ed90cfb6)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)warning:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonPhaseII/ActsMuonDetector/src/MuonDetectorBuilderTool.cxx:260:81: warning: narrowing conversion of 'lround((((__gnu_cxx::__alloc_traits<std::allocator<double>, double>::value_type)2 * Acts::TrapezoidVolumeBounds::values() const().std::vector<double>::operator[](((std::vector<double>::size_type)Acts::TrapezoidBounds::eHalfLengthXposY))) / ((double)parameters.MuonGMR4::MdtReadoutElement::parameterBook::tubePitch)))' from 'long int' to 'std::size_t' {aka 'long unsigned int'} [-Wnarrowing]
260 | std::lround(2*mdtBounds->values()[BoundsV::eHalfLengthXposY]/parameters.tubePitch), 0u},
unit-tests Error: MuonChamberToolTest 0 0 ERROR Detector: duplicate sensitive surface geometry id 'lay=242|sen=146' detected in volume 'MDT BIL eta -6 phi 1 ml 1'. Make sure a GeometryIdGenerator is used.
added review-user-action-required label and removed review-pending-level-1 label
removed review-user-action-required label
This merge request affects 16 packages:
- MuonSpectrometer/MuonPhaseII/ActsMuonDetector
- MuonSpectrometer/MuonPhaseII/Event/MuonPatternEvent
- MuonSpectrometer/MuonPhaseII/Event/MuonSpacePoint
- MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonBucketDump
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonGeometryCnv
- MuonSpectrometer/MuonPhaseII/MuonCnv/MuonHitCsvDump
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelR4
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
- MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternRecognitionAlgs
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonSpacePointFormation
- MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonTruthAlgsR4
- MuonSpectrometer/MuonPhaseII/MuonValidation/MuonObjectMarker
- MuonSpectrometer/MuonPhaseII/MuonValidation/MuonPRDTestR4
- MuonSpectrometer/MuonPhaseII/MuonValidation/MuonPatternRecognitionTest
Affected files list will not be printed in this case
Adding @apsallid ,@stavrop ,@mvozak ,@markowen ,@toyamaza ,@kluit ,@cvarni ,@pscholer ,@ddicroce ,@tbold ,@jojungge ,@wleight ,@pagessin as watchers
- Resolved by Johannes Junggeburth
CI Result FAILURE (hash 3458d59b)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)