Draft: Fixes for Pile-up SDO creation during MC Overlay jobs
In ATLASSIM-7247 it was reported that on 10th July 2024 SDO creation began to fail in MC Overlay jobs run in the main nightlies - it works in 24.0 though. I suspect that this is related to some aspect of the barcode migration, but cannot find the exact cause. SDO creation still works in pile-up digitization, so there must be another cause.
Initially it was noted that CopyMcEventCollection produced an McEventCollection with different event numbers than SimpleMergeMcEventCollTool. This has been fixed and signal GenEvents now have event_number = 0. Background GenEvents have been left as they were for now - need to find a job with pile-up truth information to test this further and update if necessary.
Next it was noted that the Bkg_TruthEvent
McEventCollection was being picked by HepMcParticleLink as the McEventCollection to which all links should point. In the case of MC Overlay jobs (without pile-up truth) then the HepMcParticleLinks in the input SimHits should point at Sig_TruthEvent
, while the SDOs should point at TruthEvent
. First Sig_TruthEvent
was added to the list of possible keys. This had the effect of making all links point at Sig_TruthEvent
(even the redirected ones). Tweaking the static HepMcParticleLink::getRedirectedLink
method to re-roll the SG::DataProxy finding allowed the redirected links for hard-scatter GenParticles to point at TruthEvent
.
At this point I think that the updates in this MR improve the output sufficiently to be worth merging, but further follow-up may be required in the future.
Merge request reports
Activity
- Resolved by John Derek Chapman
- Resolved by John Derek Chapman
added 1108 commits
-
c03ce226...419ceb0e - 1104 commits from branch
atlas:main
- 99fd6d26 - CopyMcEventCollection: Drop Separator GenEvents as we don't need them anymore (ATLASSIM-7226)
- dabd00da - HepMcParticleLink: Add Sig_TruthEvent to the list of expected HepMcParticleLink keys
- f59f4bea - HepMcParticleLink: Ensure that the redirected links point at TruthEvent rather...
- c6ebbf7f - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool
Toggle commit list-
c03ce226...419ceb0e - 1104 commits from branch
added 65 commits
-
c6ebbf7f...556933a1 - 62 commits from branch
atlas:main
- ba67cb3d - HepMcParticleLink: Add Sig_TruthEvent to the list of expected HepMcParticleLink keys
- 53c252cd - HepMcParticleLink: Ensure that the redirected links point at TruthEvent rather...
- 2a70557b - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool
Toggle commit list-
c6ebbf7f...556933a1 - 62 commits from branch
added 1 commit
- d1ea7a69 - HepMcParticleLink: changes to allow find_proxy to use a particular container name
added Generators Overlay Simulation main labels
CI Result FAILURE (hash 0fb7cb67)Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)added 1 commit
- c226ef4b - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool
added review-pending-level-1 label
CI Result FAILURE (hash c226ef4b)Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)