Skip to content
Snippets Groups Projects

Draft: Fixes for Pile-up SDO creation during MC Overlay jobs

Open John Derek Chapman requested to merge jchapman/athena:ATLASSIM-7247_main into main

In ATLASSIM-7247 it was reported that on 10th July 2024 SDO creation began to fail in MC Overlay jobs run in the main nightlies - it works in 24.0 though. I suspect that this is related to some aspect of the barcode migration, but cannot find the exact cause. SDO creation still works in pile-up digitization, so there must be another cause.

Initially it was noted that CopyMcEventCollection produced an McEventCollection with different event numbers than SimpleMergeMcEventCollTool. This has been fixed and signal GenEvents now have event_number = 0. Background GenEvents have been left as they were for now - need to find a job with pile-up truth information to test this further and update if necessary.

Next it was noted that the Bkg_TruthEvent McEventCollection was being picked by HepMcParticleLink as the McEventCollection to which all links should point. In the case of MC Overlay jobs (without pile-up truth) then the HepMcParticleLinks in the input SimHits should point at Sig_TruthEvent, while the SDOs should point at TruthEvent. First Sig_TruthEvent was added to the list of possible keys. This had the effect of making all links point at Sig_TruthEvent (even the redirected ones). Tweaking the static HepMcParticleLink::getRedirectedLink method to re-roll the SG::DataProxy finding allowed the redirected links for hard-scatter GenParticles to point at TruthEvent.

At this point I think that the updates in this MR improve the output sufficiently to be worth merging, but further follow-up may be required in the future.

Edited by John Derek Chapman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I need to process the event numbering I guess, but if this fixes the truth record, the current changes look fine to me.

  • John Derek Chapman added 1108 commits

    added 1108 commits

    • c03ce226...419ceb0e - 1104 commits from branch atlas:main
    • 99fd6d26 - CopyMcEventCollection: Drop Separator GenEvents as we don't need them anymore (ATLASSIM-7226)
    • dabd00da - HepMcParticleLink: Add Sig_TruthEvent to the list of expected HepMcParticleLink keys
    • f59f4bea - HepMcParticleLink: Ensure that the redirected links point at TruthEvent rather...
    • c6ebbf7f - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool

    Compare with previous version

  • added 65 commits

    • c6ebbf7f...556933a1 - 62 commits from branch atlas:main
    • ba67cb3d - HepMcParticleLink: Add Sig_TruthEvent to the list of expected HepMcParticleLink keys
    • 53c252cd - HepMcParticleLink: Ensure that the redirected links point at TruthEvent rather...
    • 2a70557b - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool

    Compare with previous version

  • added 1 commit

    • d1ea7a69 - HepMcParticleLink: changes to allow find_proxy to use a particular container name

    Compare with previous version

  • added 3 commits

    • 40d11fad - HepMcParticleLink: changes to allow find_proxy to use a particular container name
    • b349e885 - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool
    • 0fb7cb67 - HepMcParticleLink - a more thread-safe version of redirected links

    Compare with previous version

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • Generators/GeneratorObjects
    • Simulation/Overlay/OverlayCopyAlgs

    Affected files list will not be printed in this case

    Adding @jchapman ,@ahaas ,@tkharlam ,@tadej as watchers

  • :x: CI Result FAILURE (hash 0fb7cb67)

    Athena AthSimulation AthGeneration AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • added 2 commits

    • a2d197c8 - HepMcParticleLink: Ensure that the redirected links point at TruthEvent rather...
    • 49ea82ac - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool

    Compare with previous version

  • added 1 commit

    • c226ef4b - CopyMcEventCollection: Update behaviour to match SimpleMergeMcEventCollTool

    Compare with previous version

  • John Derek Chapman changed the description

    changed the description

  • John Derek Chapman resolved all threads

    resolved all threads

  • John Derek Chapman marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 2 packages:

    • Generators/GeneratorObjects
    • Simulation/Overlay/OverlayCopyAlgs

    Affected files list will not be printed in this case

    Adding @tkharlam ,@ahaas ,@tadej ,@jchapman as watchers

  • :x: CI Result FAILURE (hash c226ef4b)

    Athena AthSimulation AthGeneration AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading