Skip to content
Snippets Groups Projects

updates to zdc injector-pulse monitoring & adding decoding error + aux data checks in LED monitoring

Merged Yuhan Guo requested to merge yuhang/athena:zdc-led-and-pp-mode-monitor-updates into 24.0

updates to zdc injector-pulse monitoring & adding decoding error + aux data checks in LED monitoring @steinber

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good overall. Just a few questions to be addressed.

    Best, Thomas - L1

  • Yuhan Guo added 1 commit

    added 1 commit

    • 26b1d175 - deleting the line #include <cstdlib>

    Compare with previous version

  • This merge request affects 3 packages:

    • ForwardDetectors/ZDC/ZdcAnalysis
    • ForwardDetectors/ZDC/ZdcConditions
    • ForwardDetectors/ZDC/ZdcMonitoring

    Affected files list will not be printed in this case

  • WARNING: big files (>100K) are found in the changeset

    📝 116K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

  • Yuhan Guo added 1 commit

    added 1 commit

    • 252f3b11 - Added new T0 tags to config-setting script

    Compare with previous version

  • This merge request affects 4 packages:

    • ForwardDetectors/ZDC/ZdcAnalysis
    • ForwardDetectors/ZDC/ZdcConditions
    • ForwardDetectors/ZDC/ZdcMonitoring
    • ForwardDetectors/ZDC/ZdcRec

    Affected files list will not be printed in this case

  • WARNING: big files (>100K) are found in the changeset

    📝 116K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

  • CI Result SUCCESS (hash 26b1d175)

    Athena AnalysisBase AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output (remote access info)

  • CI Result SUCCESS (hash 252f3b11)

    Athena AnalysisBase AthAnalysis
    externals
    cmake
    make
    tests

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    Athena: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output (remote access info)

  • Sreelakshmi Sindhu resolved all threads

    resolved all threads

  • All threads resolved, approving -L1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading