Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Jira
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
atlas
athena
Merge requests
!75522
MuonPatternEvent - Fix tanPhi calculation bug & cure crash
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
MuonPatternEvent - Fix tanPhi calculation bug & cure crash
jojungge/athena:SegFitFixes
into
main
Overview
4
Commits
2
Pipelines
0
Changes
6
Merged
Johannes Junggeburth
requested to merge
jojungge/athena:SegFitFixes
into
main
3 months ago
Overview
4
Commits
2
Pipelines
0
Changes
6
Expand
tanPhi
was calculated wrongly as
tanTheta
by the helper function
Insert protection in the pattern visualization tool that empty accumulators are skipped with warning messages
Pattern visualization tool returns truth parameters
Tagging:
@goblirsc
,
@damperia
Edited
3 months ago
by
Johannes Junggeburth
0
0
Merge request reports
Compare
main
version 1
cd704279
3 months ago
main (base)
and
latest version
latest version
22c10b5f
2 commits,
3 months ago
version 1
cd704279
1 commit,
3 months ago
6 files
+
56
−
13
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
6
Search (e.g. *.vue) (Ctrl+P)
MuonSpectrometer/MuonPhaseII/Event/MuonPatternEvent/src/SegmentFitterEventData.cxx
+
2
−
3
Options
@@ -16,12 +16,11 @@ namespace MuonR4{
}
double
houghTanPhi
(
const
Amg
::
Vector3D
&
v
){
constexpr
double
eps
=
std
::
numeric_limits
<
float
>::
epsilon
();
return
v
.
y
()
/
(
std
::
abs
(
v
.
z
())
>
eps
?
v
.
z
()
:
eps
);
return
v
.
x
()
/
(
std
::
abs
(
v
.
z
())
>
eps
?
v
.
z
()
:
eps
);
}
namespace
SegmentFit
{
Amg
::
Vector3D
dirFromTangents
(
const
double
tanPhi
,
const
double
tanTheta
)
{
Amg
::
Vector3D
dir
=
Amg
::
Vector3D
(
tanPhi
,
tanTheta
,
1.
).
unit
();
return
tanTheta
>=
0.
?
dir
:
-
dir
;
return
Amg
::
Vector3D
(
tanPhi
,
tanTheta
,
1.
).
unit
();
}
Amg
::
Vector3D
dirFromAngles
(
const
double
phi
,
const
double
theta
)
{
const
CxxUtils
::
sincos
csPhi
{
phi
},
csTheta
{
theta
};
Loading