Skip to content
Snippets Groups Projects

ZDC: pre-pulse fit improvement

Merged Brian Andrew Cole requested to merge steinber/athena-main:24.0-zdc-fpefix into 24.0

Switch to a better pre-pulse function that implements the Run3 AKA "LHCf" shape for the main pulse Note that this was realized while looking for sources of FPEs, but it should be unrelated.

Also adjustments to injector pulse reconstruction based on look at Pb+Pb conditions

Edited by Brian Andrew Cole

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Thanks for the MR, everything looks good from my side, just the copyright needs updating ideally

    -L1

  • added 1 commit

    • a364a68a - Cosmetic change to move parameter name setting ahead of limit setting, also update copyrights

    Compare with previous version

  • Brian Andrew Cole resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • ForwardDetectors/ZDC/ZdcAnalysis

    This merge request affects 4 files:

    • ForwardDetectors/ZDC/ZdcAnalysis/Root/ZDCFitWrapper.cxx
    • ForwardDetectors/ZDC/ZdcAnalysis/Root/ZDCPulseAnalyzer.cxx
    • ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx
    • ForwardDetectors/ZDC/ZdcAnalysis/ZdcAnalysis/ZDCFitWrapper.h
  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 112K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

  • :white_check_mark: CI Result SUCCESS (hash a364a68a)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • This looks like a fairly straightforward update to ZDC processing, approving for AR.

    Nils [Analysis RC]

  • Looks good, approved.

    L1

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading