2024-11-09: merge of 24.0 into main

This sweep contains the following MRs:

• !75724 (merged) Updates to UPC chains, ATR-30471, ATR-30476 Trigger, TriggerMenu, changes-trigger-counts
• !75714 (merged) Additional chain for UPC HMT, ATR-30471 Trigger, TriggerMenu, changes-trigger-counts
• !75587 (merged) gFEX - eta centers and eta edges updated; mapping of gTowers in the Forward Region; fixing monitoring plots DQ, EDM, JetEtmiss, L1Calo, Trigger
• !75707 (merged) Update config for offline monitoring for HLT jet trigger DQ, Trigger
• !75708 (merged) ZDCFitWrapper: Fix clang compilation issues ForwardDetectors
• !75242 (merged) DAOD_IDTIDE: include Phase1 jet triggers to the trigger selection Derivation, Tracking
• !75667 (merged) ZDC changes: adjusted pulse-fitting settings and monitoring for pp-mode physics data & injector pulse; incorporated monitoring with trigger selections for pp-ref + UCC triggers ForwardDetectors, Test
• !75695 (merged) Update fixed reference for 20 GeV muon IDPVM ART test InnerDetector, PhysValidation

marked this merge request as ready

This merge request affects 13 packages:

• AtlasTest/CITest
• DataQuality/DataQualityConfigurations
• Event/xAOD/xAODTrigger
• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcMonitoring
• ForwardDetectors/ZDC/ZdcRec
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/TrigT1CaloMonitoring
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @ggonella ,@thompson ,@iriu ,@ebergeas ,@emmat ,@carquin ,@ademaria ,@goetz ,@lgagnon ,@will ,@lidiaz ,@sutt ,@slai ,@martindl ,@vmartin ,@sroe ,@ooncel ,@shanisch ,@dshope ,@stelzer ,@pagessin ,@akraszna ,@jmcgowan ,@fwinkl ,@kburka ,@jcatmore ,@gipezzul ,@jburzyns ,@keli ,@okumura ,@tamartin as watchers

added DQ Derivation EDM ForwardDetectors InnerDetector JetEtmiss L1Calo PhysValidation Test Trigger TriggerMenu analysis-review-required changes-trigger-counts main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

112K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

184K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

CI Result FAILURE

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake	N/A	N/A	N/A	N/A	N/A	N/A
make	N/A	N/A	N/A	N/A	N/A	N/A
tests	N/A	N/A	N/A	N/A	N/A	N/A

Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Jenkins please retry a build

This merge request affects 13 packages:

• AtlasTest/CITest
• DataQuality/DataQualityConfigurations
• Event/xAOD/xAODTrigger
• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcMonitoring
• ForwardDetectors/ZDC/ZdcRec
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/TrigT1CaloMonitoring
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @jcatmore ,@stelzer ,@kburka ,@goetz ,@fwinkl ,@gipezzul ,@jmcgowan ,@shanisch ,@thompson ,@ggonella ,@lidiaz ,@sroe ,@emmat ,@ademaria ,@pagessin ,@akraszna ,@dshope ,@ooncel ,@sutt ,@okumura ,@martindl ,@keli ,@lgagnon ,@ebergeas ,@slai ,@vmartin ,@carquin ,@iriu ,@will ,@tamartin ,@jburzyns as watchers

WARNING: big files (>100K) are found in the changeset

184K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

112K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

CI Result FAILURE (hash 2bbda944)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Hi @steinber, it seems ZDC tests are still failing in main (it does not seem to be caused by the current EOS instabilities). Is anyone looking into making ZDC in main compatible with the one in 24.0?

Jenkins please retry a build

This merge request affects 13 packages:

• AtlasTest/CITest
• DataQuality/DataQualityConfigurations
• Event/xAOD/xAODTrigger
• ForwardDetectors/ZDC/ZdcAnalysis
• ForwardDetectors/ZDC/ZdcMonitoring
• ForwardDetectors/ZDC/ZdcRec
• InnerDetector/InDetValidation/InDetPhysValMonitoring
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkInDet
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXByteStream
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim
• Trigger/TrigT1/TrigT1CaloMonitoring
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @tamartin ,@emmat ,@pagessin ,@kburka ,@iriu ,@akraszna ,@ggonella ,@keli ,@vmartin ,@ademaria ,@gipezzul ,@sutt ,@slai ,@will ,@okumura ,@ooncel ,@ebergeas ,@shanisch ,@stelzer ,@lgagnon ,@thompson ,@fwinkl ,@sroe ,@jcatmore ,@dshope ,@jmcgowan ,@lidiaz ,@jburzyns ,@carquin ,@martindl ,@goetz as watchers

WARNING: big files (>100K) are found in the changeset

184K in file Trigger/TriggerCommon/TriggerMenuMT/python/L1/Config/ItemDef.py

112K in file ForwardDetectors/ZDC/ZdcAnalysis/Root/ZdcAnalysisTool.cxx

CI Result FAILURE (hash 2bbda944)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Hi - that’s very strange but it’s probably just an issue in our CA configuration on main. I will look into it today.

@tsulaia, this one will need some attention. Let's wait for Peter's investigation a bit.

Hi - there are several threads here involving me. My investigations are showing that the ZdcNtuple is having issues in main, particularly with one test that is running parts of the code that it shouldn't (so keeps asking for decorations it won't find). This is probably since the changes we have made to it in 24.0 stopped getting swept, because of the huge change in the way the decorations are read back.

I fully understand I was still using a deprecated approach in 23.0 (and now 24.0) but the current situation is getting complicated. I cannot stop development on 24.0 since people need it for debugging new aspects of the detector and the reconstruction. However, I recognize this is a headache for everyone on this MR.

The options I see are to 1) disable the sweep and disable the offending test (ZDCInjCalib) in main, 2) bite the bullet and try and resolve them in the next day or so. My time is limited, but this problem isn't going away so I am happy to discuss either option.

mentioned in merge request !75781 (merged)

closed