Skip to content

Draft: Move trigger smart content lists into DerivationFrameworkTrigger

Teng Jian Khoo requested to merge khoo/athena:main-DerivationFramework-MoveTriggerContent into main

The DerivationFrameworkCore package really should not host more than essential DF infrastructure code. I suspect the trigger code went here because we didn't (want to) have a separate package for trigger DF code until now. As we have DerivationFrameworkTrigger now, we should put the trigger smart slimming code here.

One file, HLT_xAOD__MuonContainer_MuonEFInfoCPContent.py is not referenced anywhere in the repo, so was removed.

There are some other changes that would be good to do before merging:

  • AdditionalTriggerContent should be renamed to something more explicitly indicating that it is for Run 2 ID trigger content (or be merged with TrackingTriggerContent.py with some selection capability
  • Conversely, it would be good to merge the JetTrigger*Content.py files
  • We should establish if any of the FixContent is needed, and/or if any of the Include*TriggerContent flags are never used
    • IncludeEtMissTriggerContent is only true for DAOD_PHYSVAL
    • IncludeMinBiasTriggerContent is only true for DAOD_PHYSVAL
  • We should work out from which derivation formats are still being created from 25.0 which of the options are actually needed, and use that to clean up anything that isn't

As I believe PHYSVAL now ought to just include the full (ESD) trigger EDM anyway, there is no need to preserve the flags that are unique to that format, and all of those can be removed. I'd also be inclined to remove all the False settings, as they just create noise in searches, but that would be a big mechanical task over all formats, which could be factorised.

Edited by Teng Jian Khoo

Merge request reports