ISF_HepMC_Tools: use common Gaudi GTest fixture

Use the common GTest Gaudi fixture instead of copy&paste. Added the missing toolSvc accessor to the test fixture.

This also fixes a cppcheck defect on throwing in the destructor.

added full-unit-tests label

This merge request affects 2 packages:

• AtlasTest/GoogleTestTools
• Simulation/ISF/ISF_HepMC/ISF_HepMC_Tools

Affected files list will not be printed in this case

Adding @jchapman as watcher

added Simulation Test main review-pending-level-1 labels

CI integration tests for projects AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 88907dce)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output (remote access info)

added 1 commit

• 6afa36fd - ISF_HepMC_Tools: use common Gaudi GTest fixture

Compare with previous version

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 3 packages:

• AtlasTest/GoogleTestTools
• Projects/AthSimulation
• Simulation/ISF/ISF_HepMC/ISF_HepMC_Tools

Affected files list will not be printed in this case

Adding @akraszna ,@jchapman as watchers

added Build label

CI Result SUCCESS (hash 6afa36fd)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Looks good, approved.

L1

removed review-pending-level-1 label

added review-approved label

Thanks for this @fwinkl! Would you recommend that we migrate more of the Sim/Digi unit tests using GTests to the common fixture or are you planning a big MR migrating things en-masse?

I am going to have a look in the next days to see how many fit this pattern. And then we can decide.

merged

mentioned in commit 0ca88f79