Skip to content

TrigP1 DetectStreamerInfoChanges: Set error code OK for main branch (ATR-29410)

Claire Antel requested to merge cantel/athena:24.0_mod_detectstreamerinfo into 24.0

Two changes are implemented - second one for cosmetics.

1. DetectStreamerInfoChanges test always returns OK for main branch

This addresses recent trigP1_detectStreamerInfoChanges_build test failures in main due to diverging trigger EDMs between main and 24.0, which would require an update of the bs-streamerinfos.root file in both branches separately whenever there are trigger EDM changes in 24.0.

To accommodate early diverging Phase II developments in main for remainder of Run 3, have modified the DetectStreamerInfoChanges test to return an OK status always for the main branch, along with a warning message "New TStreamerInfos detected but ignoring this error for early Phase II commissioning period in main during P1 data taking.".

Remainder of test, which tests reading of the bs-streamerinfos.root file, as well as the log output, remains unmodified.

2. Use logging and info level

Currently, DetectStreamerInfoChanges test output printed to log unordered: Final message about streamer info changes appeared in middle of log file. Modified so that:

  • dictwrite.py uses logging instead of print
  • DetectStreamerInfoChanges.py uses log.info instead of log.warning for info messages.

Now each line is flushed to log immediately.

Merge request reports