Skip to content
Snippets Groups Projects

CPAlgorithms: handle missing inputs in ParticleLevelOverlapRemovalAlg

Merged Baptiste Ravina requested to merge ravinab/athena:pl_or_fix into main
All threads resolved!

This should give appropriate protection to missing input containers in the CP::ParticleLevelOverlapRemovalAlg. Note that the jet collection is for now always expected, because it's with respect to it that the overlap removal is done, though we may revisit this in the future if there's a need to support extended overlap removal strategies.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Baptiste Ravina resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms

    This merge request affects 2 files:

    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms/Root/ParticleLevelOverlapRemovalAlg.cxx
    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms/TruthParticleLevelAnalysisAlgorithms/ParticleLevelOverlapRemovalAlg.h

    Adding @krumnack ,@tadej as watchers

  • :white_check_mark: CI Result SUCCESS (hash c93b7fac)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • :white_check_mark: CI Result SUCCESS (hash b5523196)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Hi, changes look good, ask expert for a double check. @krumnack would you please take a look? Thanks, Best regards.

  • Tadej Novak
  • Changed label to review-user-action-required until the discussion is resolved. Clara (L1)

  • added 1 commit

    Compare with previous version

  • Baptiste Ravina resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms

    This merge request affects 2 files:

    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms/Root/ParticleLevelOverlapRemovalAlg.cxx
    • PhysicsAnalysis/Algorithms/TruthParticleLevelAnalysisAlgorithms/TruthParticleLevelAnalysisAlgorithms/ParticleLevelOverlapRemovalAlg.h

    Adding @krumnack ,@tadej as watchers

  • :white_check_mark: CI Result SUCCESS (hash a267b509)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • All threads resolved and CI is good, approving from L1 side (Fábio).

  • Looks good to me, approving for AR.

    Nils [Analysis RC]

  • mentioned in commit 176c2731

  • Please register or sign in to reply
    Loading