cppcheck: run checks at the package scope

By default cmake adds all the (non-system) include paths to the cppcheck command line, which causes very long processing times for some of our packages (a full build in the CI doubles from 2 to 4 hours). Add the cppcheck_atlas wrapper to remove all those -I command line arguments except for the package itself.

Use this wrapper in the Athena and WorkDir project to launch cppcheck.

The downside is that we now need to teach cppcheck about all macros used in our code base and if someone adds a new macro, which is used across package, we need to update the relevant cppcheck configuration.

Remove the suppression of the preprocessor error in CachedPointer.h and instead define the appropriate compiler variable. Not having this defined (and the error being suppressed) is one of the reasons why cppcheck was blind to a few defects in our builds (see e.g. !76484 (merged)).

Relates to ATLINFR-5443.

added full-build label

changed the description

Jenkins please retry a build

build area is cleaned as MR is labeled as full-build

This merge request affects 3 packages:

• Control/CxxUtils
• Projects/Athena
• Projects/WorkDir

Affected files list will not be printed in this case

Adding @rbianchi ,@akraszna ,@ssnyder as watchers

added Build Core main labels

changed the description

changed the description

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 81bb2f56)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 80, warnings 1425
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

added 2 commits

• 1cbb9318 - cppcheck: add wrapper for cppcheck command
• fa66d3ad - cppcheck: define additional macros

Compare with previous version

Jenkins please retry a build

build area is cleaned as MR is labeled as full-build

This merge request affects 3 packages:

• Control/CxxUtils
• Projects/Athena
• Projects/WorkDir

Affected files list will not be printed in this case

Adding @rbianchi ,@akraszna ,@ssnyder as watchers

CI Result FAILURE (hash fa66d3ad)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 77
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output (remote access info)

Unrelated ATLASG-2843 test failures

mentioned in merge request !77063 (merged)