Skip to content
Snippets Groups Projects

support for running l1topo sim and monitoring, and tidy up for efex monitoring

Merged support for running l1topo sim and monitoring, and tidy up for efex monitoring
will-24.0-patch-51a8 into 24.0
All threads resolved!
Merged Will Buttinger requested to merge will-24.0-patch-51a8 into 24.0
All threads resolved!

This MR adds a way to run the L1Topo simulation and monitoring through the master L1Calo simulation and monitoring application (L1CaloPhase1Monitoring.py).

It also tidies up some efex monitoring plots (deletes two plots that has not proved useful, and reorganizes the 'Developer' folder plots)

Merge request reports

Pipeline #9843838 passed

Stage: external

Pipeline passed for 902c4343 on will-24.0-patch-51a8

Approval is optional

Merged by Sara AlderweireldtSara Alderweireldt 5 months ago (Jan 10, 2025 4:58pm UTC)

Merge details

  • Changes merged into main with 318266f8 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :x: CI Result FAILURE (hash eeef2ab9)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :o: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Will Buttinger resolved all threads

    resolved all threads

  • Will Buttinger added 1 commit

    added 1 commit

    • 902c4343 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    This merge request affects 4 packages:

    • DataQuality/DataQualityConfigurations
    • MuonSpectrometer/MuonConfig
    • Trigger/TrigT1/L1Topo/L1TopoOnlineMonitoring
    • Trigger/TrigT1/TrigT1CaloMonitoring

    Affected files list will not be printed in this case

    Adding @orlando ,@cmorenom ,@mvozak ,@jojungge ,@stavrop ,@pscholer ,@will ,@apsallid ,@jmharris ,@stelzer ,@iriu ,@asonay ,@kluit ,@oliveirg ,@paulama ,@thompson as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot
    Developer

    :white_check_mark: CI Result SUCCESS (hash 902c4343)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output (remote access info)

  • Kira Abeling added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Kira Abeling
    Kira Abeling @kiabelin
    Developer

    Changes and CI look fine. Approving.

    Kira (L1)

  • Duc Ta added review-approved-tier0 label

    added review-approved-tier0 label

  • Sara Alderweireldt added review-approved-point1 label

    added review-approved-point1 label

  • Sara Alderweireldt mentioned in commit 318266f8

    mentioned in commit 318266f8

  • Sara Alderweireldt merged

    merged

  • Vakhtang Tsulaia mentioned in merge request !77151 (merged)

    mentioned in merge request !77151 (merged)

    • Please register or sign in to reply